Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/29472 )
Change subject: comments: gsm_08_08.h: AMR cfg: explain in much more detail
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File include/osmocom/gsm/protocol/gsm_08_08.h:
https://gerrit.osmocom.org/c/libosmocore/+/29472/comment/84c8d955_4c072ec5
PS1, Line 639: * Set bit Sn (S0 -> 0x01), where Sn is identified by a descriptive
name.
"S0 = 0x01". I first thought it was some
sort of range with the "->".
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/29472
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1864a6beeeedc301c6dc7e2e0c52a3f94b2fef01
Gerrit-Change-Number: 29472
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 25 Sep 2022 18:35:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment