laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28892 )
Change subject: BSSMAP: add assert to reset resending ......................................................................
BSSMAP: add assert to reset resending
There seems to be no way for this function to be called with NULL parameter despite unreproducible crash observed in the past. Let's add assert to show this explicitly.
Fixes: OS#5551 Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48 --- M src/osmo-bsc/bssmap_reset.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified
diff --git a/src/osmo-bsc/bssmap_reset.c b/src/osmo-bsc/bssmap_reset.c index 4d24c01..30fc02e 100644 --- a/src/osmo-bsc/bssmap_reset.c +++ b/src/osmo-bsc/bssmap_reset.c @@ -245,6 +245,8 @@
void bssmap_reset_resend_reset(struct bssmap_reset *bssmap_reset) { + OSMO_ASSERT(bssmap_reset); + /* Immediately (1ms) kick off reset sending mechanism */ osmo_fsm_inst_state_chg_ms(bssmap_reset->fi, BSSMAP_RESET_ST_DISC, 1, 0); }
-
laforge