Attention is currently required from: jolly, tnt.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/31500 )
Change subject: Send raw data with e1d as it arrives from application
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think the question is why would we allow this? Yes, it may work with e1d, but it will
likely not work with other drivers (DAHDI). In that case, I think libosmo-abis should
make sure that code will use the API in a way that will work with all drivers, and not
just with one.
Is this really enabling an actual valid use case, or is it just some kind of
"let's permit it, because we can"? Not a rhethorical question, I want to
understand!
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31500
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I3e3ef623a02bffe75b168dc42514455b4df1007f
Gerrit-Change-Number: 31500
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Thu, 02 Mar 2023 14:20:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment