Attention is currently required from: daniel, lynxis lazus.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email )
Change subject: gsup: implement a (re-)connect the GSUP link if it fails ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: The patch looks good to me in general. Just a few cosmetic things.
File src/gsup_client.erl:
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285/comment/12ce5ea0_1... PS2, Line 99: cosmetic: use tabs
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285/comment/d7a63c86_0... PS2, Line 99: Failed to This sentence looks incomplete: "failed to ..." do what? Not sure why this part is being changed at all, it looks good as it is to me.