Attention is currently required from: jolly, laforge, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email ) Change subject: Add LLC and HLC information to MNCC interface definiton ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: Neels: I think you're right. Changed to CR-1. The problem with adding new fields is that we enlarge the MNCC PDU. While it may be fine sending a larger PDU to a peer; we may have problems when a peer is sending a shorter PDU than we expect. If you're sure this works fine and: * an older version of osmo-sip-connector can still "talk" to recent osmo-msc, * an older version of osmo-msc can still "talk" to recent osmo-sip-connector, as long as they "speak" the same MNCC protocol version, we must be absolutely sure that this would not cause any fallout for the respective TTCN-3 testsuites. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15f5afcf069ee6c1c4641108ceacc837bee311b5 Gerrit-Change-Number: 35392 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 21 Dec 2023 01:47:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment