[S] Change in mncc-python[master]: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls() - gerrit-log

16 Dec 2024


      Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email )
Change subject: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls()
......................................................................
Patch Set 1:
(1 comment)
File mncc_mt_loadgen.py:
https://gerrit.osmocom.org/c/mncc-python/+/39143/comment/9adb8d6b_1155efc8?u... :
PS1, Line 185:     if len(first_msisdn_called) > needed_len:
Can this if condition ever be true? as I understand it, nr is always >= 1. So needed_len could be > len(first_msisdn_called), not the other way around?
-- 
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I2dd6b96ea2da117d67a368bc076969f25fa61a52
Gerrit-Change-Number: 39143
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 16 Dec 2024 09:00:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No