Attention is currently required from: manawyrm, laforge, pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 )
Change subject: bladerf xa4 support ......................................................................
Patch Set 6:
(7 comments)
File Transceiver52M/device/bladerf/bladerf.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5f388c55_071104ab PS1, Line 51: fprintf(stderr, "%s:%s:%d %s\n", __FILE__, __FUNCTION__, __LINE__, bladerf_strerror(status)); \
LOGP?
Done
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/06d46341_81322410 PS1, Line 240: ts_offset = 60; //static_cast<TIMESTAMP>(desc.offset * rx_rate);
maybe add some TODO/FIXME comment about this?
Done
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a839c78e_75371863 PS1, Line 422: // Create receive buffer
use comment style: /* */
Done
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a51813fd_328db405 PS1, Line 427: // Create vector buffer
well, it is C++ code after all...
Done
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/00628e80_4ed56bfa PS1, Line 466: // Start streaming
use comment style: /* */ […]
Done
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/4596e2b5_23aaf69e PS1, Line 701: relatively recent machines shows that the B100 will underrun when
B100? is this a BladeRF?
Done
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ebc6e438_6722752c PS1, Line 346: Transceiver52M/device/ipc2/Makefile \
ipc2? this is probably not related to this patch.
Done
-
Hoernchen