Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31697 ) Change subject: [codecs filter] use filter result in MT DTAP CC Setup ...................................................................... Patch Set 3: (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/31697/comment/5366c4c7_6a9f9af3 PS3, Line 711: .speech_ver = { -1 }, everything is starting to be full of magic values (-1). some UNSET defines would be great. https://gerrit.osmocom.org/c/osmo-msc/+/31697/comment/8d00e923_473951c4 PS3, Line 727: * finding a matching codec. */ but we can actually do some transoding already, like AMR BWE<->OA and AMR<->IuUP. Is this not contemplated here? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9586221ef56352b7ce4b2604ae0dc04554145a78 Gerrit-Change-Number: 31697 Gerrit-PatchSet: 3 Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 07 Mar 2023 11:23:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment