[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors - gerrit-log

5 Sep 2024

Attention is currently required from: fixeria, lynxis lazus.

pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email )

Change subject: s1ap_proxy: Support replying errors
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS4: 
...
  I did not expect my request to trigger such an
emotional burst.. 
Maybe because it's not the first time I'm seeing this (not specifically from you)
and each time it sums up.

...
  TBH, I still don't see how the metrics patch
depends on this one and why are they both in the same patch set. 
Because since both patches are of considerable span, having them in independent branches
may also create conflicts duplicating the amount of work needed.
And because I was not expecting my patch to be trapped here for more than a week.

...
   but got swallowed by  ... Yes, I too get
swallwed by other stuff, and yet it seems this doesn't affect your patches getting
merged while it actually affects mine.

...
  I am working less hours then you. 
Does that imply your patches get higher preference than mine? because it has been
clarified that testing is not a real reason comapring to your patches.
You could have merged mine and worked on top of mine, like I usually do with yours,
because I consider this helps everybody.

...
  If you wish, I can take care of this patch, i.e. keep
rebasing it and add testing coverage.
 Let it be my problem then, allowing you to focus on other features. 
You are not getting it. I don't want it to be my problem, I don't either want it
to be your problem, I don't either want it to be a problem for anybody.
Having this merged should allow *everybody* to have a shared code base to work on, without
*everybody* having to maintain extra patches on their own branches. Because then,
*everybody* is losing time with it.

-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4
Gerrit-Change-Number: 37924
Gerrit-PatchSet: 4
Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Comment-Date: Thu, 05 Sep 2024 12:05:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;