Attention is currently required from: tnt.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email )
Change subject: iCE1usb: Add support to configure CRC4 mode for TX/RX ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/vty.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/36653/comment/434e2f31_60b6ae9d PS1, Line 434: framing-tx (no-crc4|crc4)", this could be one command for both rx and tx like "framing (rx|tx) (no-crc4|crc4)". Not critical, just a thought. Especially since both the functions are 99% identical.