Attention is currently required from: fixeria, jolly, laforge, pespin.

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )

Change subject: bring twjit into libosmo-netif ......................................................................

Patch Set 6:

(4 comments)

File include/osmocom/netif/twjit.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/80548049_cc6eaf01... : PS2, Line 35: /*! buffer depth: starting minimum */

It probably makes sense to submit this or parts of this document in text format under doc/, so it ca […]

My current plan is to add a third patch to this series (after twjit and twrtp) that will add an Osmocom-controlled version of twrtp guide document to `libosmo-netif/doc`.

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/ea3ee5c1_c0b89b75... : PS2, Line 137: bool osmo_twjit_got_any_input(struct osmo_twjit *twjit);

I'll go with the shorter `osmo_twjit_rr_info_valid()` then.

Done

File src/twjit.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/7f96843f_9c5cccdb... : PS2, Line 504: rtph = osmo_rtp_get_hdr(msg);

"M bit take precedence". […]

The M bit feature was implemented in Patchset 6 as you asked. Please provide feedback.

File src/twjit.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/542e30f7_ebf7637d... : PS3, Line 331: static void analytics_cont(struct osmo_twjit *twjit, uint16_t rx_seq,

I'm currently on it reading your pdf.

Done