[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif - gerrit-log

22 Aug 2025

Attention is currently required from: fixeria, jolly, laforge, pespin.

falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )

Change subject: bring twjit into libosmo-netif
......................................................................

Patch Set 6:

(4 comments)

File include/osmocom/netif/twjit.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/80548049_cc6eaf0… :
PS2, Line 35: 	/*! buffer depth: starting minimum */
...
  It probably makes sense to submit this or parts of
this document in text format under doc/, so it ca […] My current plan is to add a
third patch to this series (after twjit and twrtp) that will add an Osmocom-controlled
version of twrtp guide document to `libosmo-netif/doc`.

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/ea3ee5c1_c0b89b7… :
PS2, Line 137: bool osmo_twjit_got_any_input(struct osmo_twjit *twjit);
...
  I'll go with the shorter
`osmo_twjit_rr_info_valid()` then. Done

File src/twjit.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/7f96843f_9c5cccd… :
PS2, Line 504: 	rtph = osmo_rtp_get_hdr(msg);
...
  "M bit take precedence". […] The M bit
feature was implemented in Patchset 6 as you asked. Please provide feedback.

File src/twjit.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/542e30f7_ebf7637… :
PS3, Line 331: static void analytics_cont(struct osmo_twjit *twjit, uint16_t rx_seq,
...
  I'm currently on it reading your pdf. Done

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 6
Gerrit-Owner: falconia &lt;falcon(a)freecalypso.org&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: jolly &lt;andreas(a)eversberg.eu&gt;
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: jolly &lt;andreas(a)eversberg.eu&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Fri, 22 Aug 2025 21:29:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia &lt;falcon(a)freecalypso.org&gt;
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;