Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email ) Change subject: asp: Introduce support to configure and enable TCP keep-alive ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/a71e40f6_ac62e… : PS2, Line 800: rc = You're assigning a value to `rc`, but then after the `switch` it gets overwritten. File src/ss7_asp_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/15830fce_6cc78… : PS2, Line 512: "num-ostreams" Where these values are coming from? They're not part of `ASP_TCP_PARAM_KEEPALIVE_CFG_FIELDS`. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1 Gerrit-Change-Number: 40481 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jun 2025 12:57:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes