Attention is currently required from: pespin, fixeria.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32050 )

Change subject: gmm: Initial implementation of GPRS Detach ......................................................................

Patch Set 1: Code-Review+1

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32050/comment/e8830507_35898898 PS1, Line 11: implementation, initial Tx and Rx of some GMM messages, etc. (would probably be easier to review if this was split into multiple patches, but I guess you had a reason for doing it that way)

File src/gmm/gmm.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32050/comment/e744dceb_247dd55f PS1, Line 376: /* TODO: kept this on purpose?

https://gerrit.osmocom.org/c/libosmo-gprs/+/32050/comment/7bfdf7cc_a470880f PS1, Line 471: force_stanbdy_indicated typo in standby