Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29965 )

Change subject: Split gsn_t related APIs out of gtp.{c,h} ......................................................................

Patch Set 2:

(60 comments)

File gtp/gsn.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/fbd38d8f_a2acd73a PS2, Line 68: int (*cb_delete_context) (struct pdp_t *); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/2c9323de_81fa1f2a PS2, Line 68: int (*cb_delete_context) (struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/8962611a_ce42e6c9 PS2, Line 69: int (*cb_create_context_ind) (struct pdp_t *); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/8b1e5446_7df8fc99 PS2, Line 69: int (*cb_create_context_ind) (struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/f422ffdf_b28ec5b5 PS2, Line 70: int (*cb_unsup_ind) (struct sockaddr_in * peer); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/101f16e0_1671a620 PS2, Line 70: int (*cb_unsup_ind) (struct sockaddr_in * peer); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/a8ce71bb_3cc75633 PS2, Line 71: int (*cb_extheader_ind) (struct sockaddr_in * peer); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/73913059_63c71e22 PS2, Line 71: int (*cb_extheader_ind) (struct sockaddr_in * peer); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c73e686f_c6497344 PS2, Line 72: int (*cb_ran_info_relay_ind) (struct sockaddr_in *peer, union gtpie_member **ie); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/26c2a155_c6aee6b5 PS2, Line 73: int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/85b6d4b6_dd913dce PS2, Line 73: int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/354e8270_6b4aee5e PS2, Line 74: int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/518032aa_ee5aba9a PS2, Line 74: int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/84f82b27_ffeace82 PS2, Line 75: int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b0eb4e1b_1af5c4e3 PS2, Line 75: int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/2a4243bd_be432467 PS2, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/350aa938_60e106db PS2, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/82421d7b_fbad7f3e PS2, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/0fd939c0_87ada9ef PS2, Line 77: int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, struct pdp_t *pdp, uint8_t recovery); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/58bf8ec4_9a00ea83 PS2, Line 120: int (*cb_create_context_ind) (struct Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/3f278297_3051f66c PS2, Line 124: int (*cb_data_ind) (struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/016ff5c4_21e85317 PS2, Line 124: int (*cb_data_ind) (struct pdp_t * pdp, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/be410462_804a97b6 PS2, Line 127: int (*cb_delete_context) (struct pdp_t * Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/07e16334_d569ab61 PS2, Line 133: int (*cb) (struct sockaddr_in * peer)); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/93de1f68_0f70da2c PS2, Line 133: int (*cb) (struct sockaddr_in * peer)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/ead4ba4a_bf6315e9 PS2, Line 136: int (*cb) (struct sockaddr_in * peer)); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/f36a30c7_1f73beb3 PS2, Line 136: int (*cb) (struct sockaddr_in * peer)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/8a6a8095_a847d240 PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/3026edf1_e86d3c29 PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/f8af598d_b06e21a6 PS2, Line 142: int (*cb) (int type, int cause, struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/0f024527_373f3ac3 PS2, Line 142: int (*cb) (int type, int cause, struct pdp_t * pdp, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b8377639_8d9a47c8 PS2, Line 146: int (*cb) (struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b3f37a56_f534f2db PS2, Line 146: int (*cb) (struct sockaddr_in * peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/1d34e097_9db694f4 PS2, Line 150: int (*cb) (struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/6f6be6e3_8d309a43 PS2, Line 150: int (*cb) (struct sockaddr_in * peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/6caa6681_08945fc7 PS2, Line 151: struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/876b9644_31669909 PS2, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/8d42b26f_e311b543 PS2, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/319a4cb2_cb27cd48 PS2, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/df0db762_2f4dab98 PS2, Line 156: struct pdp_t * pdp, "foo * bar" should be "foo *bar"

File gtp/gsn.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/6187c0ee_75a58d98 PS2, Line 70: #define LOGP_WITH_ADDR(ss, level, addr, fmt, args...) \ macros should not use a trailing semicolon

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c4e0d43a_2a0aa118 PS2, Line 125: int (*cb) (struct sockaddr_in * peer)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/70c32a01_f9456ead PS2, Line 125: int (*cb) (struct sockaddr_in * peer)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/0378d3e0_83f880c6 PS2, Line 132: int (*cb) (struct sockaddr_in * peer)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/855609d5_93af7d54 PS2, Line 132: int (*cb) (struct sockaddr_in * peer)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/9df6ef74_52259fcf PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b8073bc6_b19fe38f PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/97308222_54db4f7f PS2, Line 147: int gtp_set_cb_delete_context(struct gsn_t *gsn, int (*cb) (struct pdp_t * pdp)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/5b7dcb1b_29d2e948 PS2, Line 154: int (*cb) (int type, int cause, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/453fe63d_9463a6f9 PS2, Line 155: struct pdp_t * pdp, void *cbp)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/e2087ba4_adfb3c7d PS2, Line 162: int (*cb) (struct sockaddr_in * peer, uint8_t recovery)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/f888493f_0e52a467 PS2, Line 162: int (*cb) (struct sockaddr_in * peer, uint8_t recovery)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/cf7b6f5a_0c85b5ce PS2, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/8cff92f4_08666c69 PS2, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/f8d211dd_2dcee125 PS2, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/1eee74a7_147bbe08 PS2, Line 190: int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/5bed4ea9_2c19ed5a PS2, Line 198: int (*cb_data_ind) (struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4d123069_a934dd69 PS2, Line 198: int (*cb_data_ind) (struct pdp_t * pdp, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b51b6066_267e3d19 PS2, Line 517: int (*cb_create_context_ind) (struct pdp_t * Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-671): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/db39ab5b_18474288 PS2, Line 536: } adding a line without newline at end of file