daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715 ) Change subject: Improve log levels, documentation ...................................................................... Improve log levels, documentation * DGPRS should not set level to debug by default * Remove log message about pooling being disabled * Fix documentation of gbproxy_cleanup_bvcs() parameters Change-Id: Ieddf20a5eafaa9738d5d1e9a9aae320e48aa2efc --- M src/gb_proxy.c M src/gb_proxy_main.c M src/gb_proxy_peer.c 3 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/15/29715/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 488ef91..aa8ad8a 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -281,7 +281,7 @@ return NULL; } - LOGPSGSN(sgsn, LOGL_INFO, "Pooling disabled, using first available SGSN\n"); + LOGPSGSN(sgsn, LOGL_DEBUG, "Pooling disabled, using first available SGSN\n"); } else { /* Pooling is enabled, try to use the NRI for routing to an SGSN * See 3GPP TS 23.236 Ch. 5.3.2 */ diff --git a/src/gb_proxy_main.c b/src/gb_proxy_main.c index 1a4e951..80d6908 100644 --- a/src/gb_proxy_main.c +++ b/src/gb_proxy_main.c @@ -237,12 +237,14 @@ [DGPRS] = { .name = "DGPRS", .description = "GPRS Packet Service", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, + .loglevel = LOGL_INFO, }, [DOBJ] = { .name = "DOBJ", .description = "GbProxy object allocation/release", .enabled = 1, + .loglevel = LOGL_INFO, .color = "\033[38;5;121m" }, }; diff --git a/src/gb_proxy_peer.c b/src/gb_proxy_peer.c index 1e300ad..e4cb49f 100644 --- a/src/gb_proxy_peer.c +++ b/src/gb_proxy_peer.c @@ -137,8 +137,7 @@ } /*! remove BVCs on NSE specified by NSEI. - * \param[in] cfg proxy in which we operate - * \param[in] nsei NS entity in which we should clean up + * \param[in] nse NS entity in which we should clean up * \param[in] bvci if 0: remove all PTP BVCs; if != 0: BVCI of the single BVC to clean up */ int gbproxy_cleanup_bvcs(struct gbproxy_nse *nse, uint16_t bvci) { -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ieddf20a5eafaa9738d5d1e9a9aae320e48aa2efc Gerrit-Change-Number: 29715 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange