Attention is currently required from: iedemam, pespin, daniel.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 )
Change subject: stats: sanitize tcp stat name identifiers
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
What's strange to me then is why don't we have already some sort of API to sanitize string so that t […]
I think the fundamental problem is that many of us never really used the statsd exporter much, so all our current sanitizing needs were oriented towards CTRL interface, whether directly or indirectly.
PS1:
Yes, the patch is simple but I don't really think the generated strings are less ugly. stastd may be happy, but _-_ sequences? ...
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/27137
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2
Gerrit-Change-Number: 27137
Gerrit-PatchSet: 1
Gerrit-Owner: iedemam
michael@kapsulate.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: iedemam
michael@kapsulate.com
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Fri, 11 Feb 2022 13:55:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam
michael@kapsulate.com
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment