laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/28711 ) Change subject: ts_31_102: Fix EF_EPSLOCI argument ordering ...................................................................... ts_31_102: Fix EF_EPSLOCI argument ordering We were invoking the constructor with the description as 4th positional argument, but that was actually the 'size' argument in this case. Let's swap the order to be aligned with other file constructors. Change-Id: I9acee757f096fef0d8bacbec3b52f56267cd52f6 --- M pySim/ts_31_102.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 5df7369..aa36b71 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -860,8 +860,8 @@ # TS 31.102 Section 4.2.91 class EF_EPSLOCI(TransparentEF): - def __init__(self, fid='6fe3', sfid=0x1e, name='EF.EPSLOCI', size=(18, 18), - desc='EPS Location Information', **kwargs): + def __init__(self, fid='6fe3', sfid=0x1e, name='EF.EPSLOCI', + desc='EPS Location Information', size=(18,18), **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, **kwargs) upd_status_constr = Enum( Byte, updated=0, not_updated=1, roaming_not_allowed=2) 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9acee757f096fef0d8bacbec3b52f56267cd52f6 Gerrit-Change-Number: 28711 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged