Attention is currently required from: daniel, laforge, pespin.

arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst ......................................................................

Patch Set 2:

(1 comment)

File include/osmocom/core/gsmtap_util.h:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/5164a842_f5a40261 PS2, Line 30:

I think it may be a good idea to add the new symbol as gsmtap_inst_fd2() and change the known client […]

Instead of adding `gsmtap_inst_fd2()`, I could also just keep using `wq.bfd.fd` through the `wq` member of `struct gsm_inst` for Osmo IO, only acessing it through `gsmtap_inst_fd()` even internally. That should work, because Osmo IO will replace usage of the write queue altogether.

And if by 'changing the internal structure', you meant getting rid of the `wq` struct member altogether and adding, say a member `int fd` internally, that can also easily be done then later. And we avoid adding an additional API function.

Any objections to that?