Attention is currently required from: osmith, neels, pespin, fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 )
Change subject: GSMTAP: allow configuring src IP for log messages ......................................................................
Patch Set 12:
(4 comments)
File src/core/logging_gsmtap.c:
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/3f7e0f0b_df54b0b4 PS12, Line 132: gsmtap_source_free(target->tgt_gsmtap.gsmtap_inst);
You could try comparing if new ip if same as the old one and then do nothing. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/91ba331e_575878e4 PS12, Line 139: if (ip)
if without {} and else with them. Fix.
Done
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/58d640f9_189e6c6a PS12, Line 186: target->tgt_gsmtap.src_addr = talloc_strdup(target, src);
I hope arget->tgt_gsmtap.src_addr is NULL here and we are not leaking.
Exactly the same reasoning can be applied to hostname and ident - nothing is changed in this regard by adding one more parameter. So if there's a chance of leaking src_addr than we're also leaking hostname and ident as well. Do you have some actionable suggestion?
File utils/osmo-stat-dummy/osmo-stat-dummy.cfg:
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/3e7eff23_f398789e PS4, Line 1: log gsmtap 127.0.0.69 127.6.9.1
1- 127.0.0.1/8 always exist on linux for IPv4 (not even the case for IPv6 iirc). […]
1 - yes, 127.0.0.1/8 is an IPv4 address? 2 - sorry, I'm completely at loss as to what's your actual point
I'm adding new parameter to logging config and I'm illustrating its use in a config file in the same commit. Do you have some concrete suggestion on what should be done differently?
-
msuraev