Change in osmo-bsc[master]: pcu_sock: rework check logic for ts - gerrit-log

5 Jan 2023


      Attention is currently required from: fixeria, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30876 )
Change subject: pcu_sock: rework check logic for ts
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30876/comment/cd44d0ba_6d074cd5 
PS2, Line 96: static bool ts_is_pdch(const struct gsm_bts_trx_ts *ts)
ts_should_be_pdch() in osmo-bts.git (the coutnerpart of this function) looks more complex, probably checking properly dynamic TS.
I bet dynamic TS are not going to work with current code in osmo-bsc? (maybe we don't care at all because RBS doesn't support dynamic TS).
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30876
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icaab52ab73c38889dfadb523b89bb54cafacc99a
Gerrit-Change-Number: 30876
Gerrit-PatchSet: 2
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 05 Jan 2023 17:02:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment