Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30330 )
Change subject: mobile: gsm48_rr_set_mode(): print error if ch_type is not TCH ......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/mobile/gsm48_rr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30330/comment/8f4f66ec_df3475a4 PS1, Line 3441: LOGP(DRR, LOGL_ERROR, "CHANNEL MODE MODIFY only applies "
That log message makes it clear that the channel is not TCH/* but it doesn't which channel it actual […]
Actually, we should not be logging an error here because this function may get called not only for CHANNEL MODE MODIFY. In such cases it should simply return early, as it does.