Attention is currently required from: laforge, manawyrm. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34745?usp=email ) Change subject: gsm48_ie.c: force rate adaptation mode for CSD calls to V.110 ...................................................................... Patch Set 3: -Code-Review (1 comment) Patchset: PS3: Actually, I am not really sure if we want to guess or make assumptions in a library function doing parsing of the BCap. IMO, it's better if the intermediate structure (where we parse to) reflects what's on the wire as close as possible. Maybe move this logic to osmo-msc.git, where we do the parsing? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I260834f3d28034afa6b50a6ca8c89accba8fa65b Gerrit-Change-Number: 34745 Gerrit-PatchSet: 3 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 14 Oct 2023 20:08:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment