[L] Change in ...osmo-s1gw[master]: [REST] Implement MetricsList - gerrit-log

25 Sep 2025


      Attention is currently required from: fixeria, laforge, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email )
Change subject: [REST] Implement MetricsList
......................................................................
Patch Set 8:
(1 comment)
File doc/osmo-s1gw-cli.md:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099/comment/123d2637_639f4... :
PS7, Line 109: | pfcp.assoc_setup_req.timeout  | counter |      21 |
...
imho it would be better to have those as "c" and "g", otherwise it populates a lot of space. […]
Having metric types in a separate column looks more readable to me than those cryptic single-later suffixes. Though, I don't have a strong preference and would like to hear what the others think (also, ideally, what the customer wants).
-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I43114aa8f5f8a388dd6a436f83ad1ee97f1d2ab1
Gerrit-Change-Number: 41099
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 25 Sep 2025 08:23:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de