Attention is currently required from: fixeria, jolly, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email )
Change subject: osmo-bts-virtual: Port over to osmo_io
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bts-virtual/virtual_um.c:
https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/e2ba64f8_b4a873c3
PS2, Line 53: (rc == 0)
I meant this file when I said: If the socket dies, not
handling of rc <= 0 will result in an infinit […]
I'm not sure how an UDP
socket could ever "die" unless we were to close it from some other part of our
own code (which we don't, and would be a separate bug).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icfe42da00fd446c38090055e2baa5d5e0ae5b70c
Gerrit-Change-Number: 36317
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2024 13:04:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: comment