[M] Change in osmo-sip-connector[master]: verbosely log MNCC and SDP - gerrit-log

11 Dec 2023


      Attention is currently required from: fixeria, neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308?usp=email )
Change subject: verbosely log MNCC and SDP
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mncc.c:
https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308/comment/842e8832_c07... 
PS2, Line 1059: Log about the received MNCC message
...
Given that this whole new code chunk is only for `LOGL_DEBUG` logging, I think it can be moved into  […]
the cost of calling log_check_level() and the conditional is probably bigger than going through the switch statement, so I see no benefit.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ie923117929c6b79b1eb61e5a9f02a169edabc599
Gerrit-Change-Number: 35308
Gerrit-PatchSet: 2
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 11 Dec 2023 10:17:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment