Attention is currently required from: fixeria, neels.
Patch set 2:Code-Review +1
View Change
1 comment:
File src/mncc.c:
Patch Set #2, Line 1059: Log about the received MNCC message
Given that this whole new code chunk is only for `LOGL_DEBUG` logging, I think it can be moved into […]
the cost of calling log_check_level() and the conditional is probably bigger than going through the switch statement, so I see no benefit.
To view, visit change 35308. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ie923117929c6b79b1eb61e5a9f02a169edabc599
Gerrit-Change-Number: 35308
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Dec 2023 10:17:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment