Attention is currently required from: osmith, fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465 to look at the new patch set (#2). Change subject: treewide: tweak includes ...................................................................... treewide: tweak includes Categorize includes by: * (library includes) * Osmocom includes except for OsmoBSCNAT * OsmoBSCNAT includes Order the includes in each category alphabetically, and remove empty lines between them. This allows me to keep them consistent, and with empty lines removed between these categories it doesn't look inconsistent if there is only one include from two categories in one file, but multiple includes from the same category in another file. While at it, also have one empty line after the license header in all c, h files, and one after the includes. Related: SYS#5560 Change-Id: I1a7b95ccb0c87fd53645c72f0c02449e8403043b --- M include/osmocom/bsc_nat/bsc_nat.h M include/osmocom/bsc_nat/bsc_nat_fsm.h M include/osmocom/bsc_nat/logging.h M src/osmo-bsc-nat/bsc_nat.c M src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/logging.c M src/osmo-bsc-nat/main.c M src/osmo-bsc-nat/vty.c 8 files changed, 6 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/65/27465/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1a7b95ccb0c87fd53645c72f0c02449e8403043b Gerrit-Change-Number: 27465 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset