Attention is currently required from: fixeria.

Hello Jenkins Builder, osmith, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42428?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed: Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.

Change subject: enb_proxy: obtain sctp_client sockopts from the env directly ......................................................................

enb_proxy: obtain sctp_client sockopts from the env directly

Instead of passing the MmeConnCfg (sctp_client:cfg()) all the way from osmo_s1gw_sup through sctp_server (as priv) into enb_proxy (as state), read the sctp_client configuration in-place via osmo_s1gw:get_env/2 when it is actually needed (connecting/enter).

This works because osmo_s1gw_sup already normalizes and writes back the complete sctp_client config to the application env (set_env/2) before starting the supervision tree.

As a result, mme_conn_cfg is removed from enb_proxy's state record, start_link/2 no longer uses its Priv argument, and server_cfg/1 is simplified to server_cfg/0.

Change-Id: Ic77d3eb3351c8981c87fa4b6febcdeb814b9187b --- M src/enb_proxy.erl M src/osmo_s1gw_sup.erl 2 files changed, 9 insertions(+), 12 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/28/42428/2