laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email ) Change subject: ttcn3-bts-test: do not use respawn.sh ...................................................................... ttcn3-bts-test: do not use respawn.sh Re-spawning osmo-bts is no longer necessary. For quite some time now, it has been able to attempt OML link re-establishment in a loop instead of exit()ing. Additionally, using respawn.sh makes crashes harder to detect. Whether we should restart the IUT process and continue executing the remaining test cases after a crash is debatable. However, none of the other testsuites (except ttcn3-pcu-test, which actually requires restarting osmo-pcu after each TC) use respawn.sh for that purpose. Change-Id: I770a0530f90c5e03d2073bfc1c4cfd0e840379c9 Related: OS#6728, OS#6729 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 40c00ac..d4b59e7 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -40,7 +40,6 @@ start_bts() { local variant variant="$1" - sleep_time_respawn="$2" echo Starting container with BTS if [ -z "$variant" ]; then echo ERROR: You have to specify a BTS variant @@ -51,11 +50,10 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/bts:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ - -e "SLEEP_BEFORE_RESPAWN=$sleep_time_respawn" \ --name ${BUILD_TAG}-bts -d \ $DOCKER_ARGS \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ - /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" + /bin/sh -c "osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" } start_fake_trx() { -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I770a0530f90c5e03d2073bfc1c4cfd0e840379c9 Gerrit-Change-Number: 39597 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>