laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34121 )
Change subject: sgsn_rim: do not check the origin of a RIM message ......................................................................
sgsn_rim: do not check the origin of a RIM message
When we forward RIM messages from GTP to BSSGP, we do not have to check the origin of the message since it does not matter from which origin the message came when we are forwarding it.
Related: OS#6095 Change-Id: Iea8176dcfe64c25d207bafc0ef61ca9d9ad415be --- M src/sgsn/sgsn_rim.c 1 file changed, 14 insertions(+), 7 deletions(-)
Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved
diff --git a/src/sgsn/sgsn_rim.c b/src/sgsn/sgsn_rim.c index c4a4a78..c6f8dcd 100644 --- a/src/sgsn/sgsn_rim.c +++ b/src/sgsn/sgsn_rim.c @@ -93,13 +93,6 @@ /* Receive a RIM PDU from GTPv1C (EUTRAN) */ int sgsn_rim_rx_from_gtp(struct bssgp_ran_information_pdu *pdu) { - if (pdu->routing_info_src.discr != BSSGP_RIM_ROUTING_INFO_EUTRAN) { - LOGP(DRIM, LOGL_ERROR, "Rx GTP RAN Information Relay: Expected src %s, got %s\n", - bssgp_rim_routing_info_discr_str(BSSGP_RIM_ROUTING_INFO_EUTRAN), - bssgp_rim_routing_info_discr_str(pdu->routing_info_src.discr)); - return -EINVAL; - } - if (pdu->routing_info_dest.discr != BSSGP_RIM_ROUTING_INFO_GERAN) { LOGP(DRIM, LOGL_ERROR, "Rx GTP RAN Information Relay: Expected dst %s, got %s\n", bssgp_rim_routing_info_discr_str(BSSGP_RIM_ROUTING_INFO_GERAN),