Attention is currently required from: fixeria, neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Patchset: PS6: To me everything looks correct. The code is also well documented. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/60435238_55e6b80b?usp=em… : PS6, Line 117: If self.value is None, first call self.validate() to generate a sanitized self.value from self.input_value. This comment reads like if it were the API users task to call self.validate if self.value is none. But in the code below it is automatically done. I think that is also what you want to explain here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 15:44:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes