Attention is currently required from: fixeria, neels.

dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )

Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ......................................................................

Patch Set 6: Code-Review+1

(2 comments)

Patchset:

PS6: To me everything looks correct. The code is also well documented.

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/39742/comment/60435238_55e6b80b?usp=ema... : PS6, Line 117: If self.value is None, first call self.validate() to generate a sanitized self.value from self.input_value. This comment reads like if it were the API users task to call self.validate if self.value is none. But in the code below it is automatically done. I think that is also what you want to explain here.