Attention is currently required from: fixeria, neels.

Patch set 6:Code-Review +1

View Change

2 comments:

• Patchset:

  • Patch Set #6:

    To me everything looks correct. The code is also well documented.

• File pySim/esim/saip/personalization.py:

  • Patch Set #6, Line 117: If self.value is None, first call self.validate() to generate a sanitized self.value from self.input_value.

    This comment reads like if it were the API users task to call self.validate if self.value is none. But in the code below it is automatically done. I think that is also what you want to explain here.

To view, visit change 39742. To unsubscribe, or for help writing mail filters, visit settings.