Attention is currently required from: fixeria, lynxis lazus, osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895?usp=email )
Change subject: epdg: Test Handover from Wifi back to LTE
......................................................................
Patch Set 2:
(2 comments)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895/comment/a103b860_cd68…
PS1, Line 451: setverdict(pass);
you explicitly mention cause="Access changed from
non-3gpp to 3gpp" below. […]
The cause you mention is sent by us (ttcn3
emulating PGW) to osmo-epdg in DeleteBearerRequest, so no need to validate what we are
sending here :)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895/comment/dc9aa6df_2511…
PS1, Line 459: /* f_gtp2_register_udmsg('63'O); TODO: is this needed? */
do you want to keep this? (if the test works without
it, I guess it is not needed?)
Ack I forgot to drop it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I299faf28fa51dbc5d2de6c72a39a01eca67a5775
Gerrit-Change-Number: 34895
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 27 Oct 2023 14:14:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment