Attention is currently required from: jolly, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email )
Change subject: Implement M3UA-over-TCP (in addition to SCTP) ......................................................................
Patch Set 5:
(2 comments)
File include/osmocom/sigtran/osmo_ss7.h:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/5d4f6717_bc82e8eb PS3, Line 616: osmo_sccp_simple_client2(void *ctx, const char *name, uint32_t default_pc,
So at least submit that part as a different patch and we can discuss whether we merge it [...]
https://gerrit.osmocom.org/c/libosmo-sccp/+/35999
Closing the thread.
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/58b0f457_db6920d0 PS4, Line 133: #define PROTO_MUX(proto, trans_proto) \
if we do it like it's done here, there should be a static_assert, as I mentioned. […]
Done
-
fixeria