Attention is currently required from: laforge, pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Patch Set 21: (2 comments) File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/5e997766_64e5457e PS21, Line 14: esme You marked my comment as resolved without responding. struct naming seems unclear; we now have struct esme and struct smpp_esme, right? api doc explanation of the difference would be good File src/utils/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/57114f65_ac22c05a PS19, Line 45: $(top_builddir)/src/libvlr/libvlr.a \ struct gsm_network contains opaque pointers to vlr_instance, that shouldn't pull in libvlr as dependency; is it gsm_network_init()? this is not so important, but seems like an easy way out here -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 21 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:01:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment