Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31007 ) Change subject: modem: Initial integration of libosmo-gprs-{llc,sndcp} ...................................................................... Patch Set 2: (2 comments) File src/host/layer23/src/modem/llc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2880): https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/3cc6b091_e5be89a4 PS2, Line 66: if (llc_prim->ll.l3_pdu_len > 0) { braces {} are not necessary for single statement blocks File src/host/layer23/src/modem/sndcp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2880): https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/79754578_dd0ece35 PS2, Line 201: } adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I820328009ccdd1f8112aeb163efa064ec1465d2a Gerrit-Change-Number: 31007 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Jan 2023 20:09:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment