Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 )
Change subject: add option to send SCCP CR without payload
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-hnbgw/hnbgw_rua.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/41e863c1_79f7b23a
PS1, Line 274: if (data && len && map && !map->is_ps
&& !release_context_map) {
So data is already checked above in line 267, which
means this should have already been in place bef […]
Before this patch, we never
called rua_to_scu() with NULL data.
So i don't really agree but it's ok, i can separate.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328
Gerrit-Change-Number: 28230
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Jun 2022 20:32:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment