Attention is currently required from: fixeria, laforge.

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37643?usp=email )

Change subject: ara_m: add export support for the ARA-M application ......................................................................

Patch Set 3:

(1 comment)

File pySim/ara_m.py:

https://gerrit.osmocom.org/c/pysim/+/37643/comment/aaf0937c_11dd4895?usp=ema... : PS2, Line 425: if 'ref_ar_do' in ref_ar_do_list: : for ref_ar_do in ref_ar_do_list['ref_ar_do']: : if 'ref_do' in ref_ar_do: : ref_do_list = ref_ar_do['ref_do'] : if 'ar_do' in ref_ar_do: : ar_do_list = ref_ar_do['ar_do'] : : if ref_do_list and ar_do_list: : aid_ref_do = None : dev_app_id_ref_do = None : apdu_ar_do = None : nfc_ar_do = None : perm_ar_do = None : pkg_ref_do = None : for ref_do in ref_do_list: : if 'aid_ref_do' in ref_do: : aid_ref_do = ref_do['aid_ref_do'] : if 'dev_app_id_ref_do' in ref_do: : dev_app_id_ref_do = ref_do['dev_app_id_ref_do'] : if 'pkg_ref_do' in ref_do: : pkg_ref_do = ref_do['pkg_ref_do'] : for ar_do in ar_do_list: : if 'apdu_ar_do' in ar_do: : apdu_ar_do = ar_do['apdu_ar_do'] : if 'nfc_ar_do' in ar_do: : nfc_ar_do = ar_do['nfc_ar_do'] : if 'perm_ar_do' in ar_do: : perm_ar_do = ar_do['perm_ar_do']

why do we need all those maipulations? it's a lot of hand-written code which I'd rather avoid (also, […]

I have put it into a helper function, now it is much shorter.