[M] Change in osmocom-bb[master]: ASCI: Get timing advance and TX power only when included - gerrit-log

26 Sep 2023


      Attention is currently required from: pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34477?usp=email )
Change subject: ASCI: Get timing advance and TX power only when included
......................................................................
Patch Set 5:
(1 comment)
File src/host/layer23/src/mobile/gsm48_rr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34477/comment/139b4d3b_34f760eb 
PS4, Line 4982: 		msg->cb[0] = rllh->link_id;
...
why are you adding this? I don't see it being used in gsm48_rr_rx_acch?
It is later used in a patch to determine between FACCH or SACCH. I moved that line to the correct patch.
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34477?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I87fcd44bba221ab4c5fbd2c79557db2444a10b88
Gerrit-Change-Number: 34477
Gerrit-PatchSet: 5
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 26 Sep 2023 10:24:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment