[S] Change in osmo-bts[master]: csd_v110: properly set bit E2 for TCH/F4.8 NT - gerrit-log

27 Sep 2024


      Attention is currently required from: fixeria.
falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email )
Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
...
Hm, then Harald's code in `gsmtap_csd_rlp_process()` should also be wrong.
Yes, it is also wrong!
...
Yes, such a flag can be calculated from current TDMA Fn then.
See here:
https://gerrit.osmocom.org/c/osmo-bts/+/38304
I haven't touched the gsmtap code yet, mostly because I don't understand it.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If8307a9ce0fdc6da45157149ccef7b840ff9d9b3
Gerrit-Change-Number: 38301
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia falcon@freecalypso.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 27 Sep 2024 10:21:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia falcon@freecalypso.org
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de