Attention is currently required from: arehbein, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32075 ) Change subject: gsm_objclass2mo(): Change signature/set NACK cause ...................................................................... Patch Set 8: (2 comments) File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/38fa0d07_8fbd13e2 PS8, Line 1107: return oml_fom_ack_nack(msg, NM_NACK_OBJINST_UNKN); you are missing passing "c" here instead of fixed NM_NACK_OBJINST_UNKN. https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/c868bc9f_a10cd823 PS8, Line 1153: return oml_fom_ack_nack(msg, NM_NACK_OBJINST_UNKN); same, missing passing "c". -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I37e6b23ed95260a8188910cf9754faffcba519c5 Gerrit-Change-Number: 32075 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Apr 2023 22:53:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment