Attention is currently required from: laforge, pespin, lynxis lazus, matanp.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32712 )
Change subject: Add FPLMN read and program
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File pysim-testdata/sysmoUSIM-SJS1.ok:
https://gerrit.osmocom.org/c/pysim/+/32712/comment/00c594c6_a6012fe0
PS5, Line 108: 62f201 # MCC: 262 MNC: 010
I would think so. […]
I also think that changing the type of derive_mcc and derive_mnc to str is the best solution. I only hope that the follow up changes would not grow too complex. In case you run into problems here you also can add ad _str variant of derive_mxc. We already have this with dec_mcc_from_plmn and dec_mcc_from_plmn_str for example.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/32712
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ce8c1af691c28ea9ed69e7b5f03f0c02d1f029b
Gerrit-Change-Number: 32712
Gerrit-PatchSet: 6
Gerrit-Owner: matanp
matan1008@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: matanp
matan1008@gmail.com
Gerrit-Comment-Date: Thu, 01 Jun 2023 08:39:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu
Comment-In-Reply-To: matanp
matan1008@gmail.com
Gerrit-MessageType: comment
dexter