Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39556?usp=email ) Change subject: s1ap_proxy: catch exceptions in handle_pdu/2 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/s1ap_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39556/comment/3056dcff_e2e0… : PS1, Line 240: {{forward, OrigData}, S0} %% XXX: proxy as-is or drop? If you carefully look at the code, you'll see that it's already done in three steps: * `decode_pdu/1` - parsing/decoding, * `handle_pdu/2` - processing (patching), * `encode_pdu/1` and return - encoding and sending. The message type is already known here, as well as the criticality, so we can improve this aspect in follow-up patches. For now I simply want to address one specific problem: crashing process and loosing all E-RABs if something goes wrong in `handle_pdu/2`. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib1e6674f5b85557866c7beaea710ea903e4eeaca Gerrit-Change-Number: 39556 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Feb 2025 17:19:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>