Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email ) Change subject: gtp_new(): use talloc instead of calloc/free ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File gtp/gsn.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38930/comment/94199162_0cd2cbbb?us… : PS3, Line 592: tall_gsn_ctx slight naming inconsistency: The name of the context is "libgtp" (which is a specific library, likely a generic name for the entire library) while the name is tall_gsn_ctx which seems to indicate it is about the GSN? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b Gerrit-Change-Number: 38930 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 16:07:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes