Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27818
)
Change subject: lchan_fsm: Ignore other SAPIs of RLL_REL_IND for SAPI=0 is received
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/lchan_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27818/comment/7ceeb0b4_3d4b1028
PS1, Line 1207: /* if SAPI=0 is gone, it makes no sense if other SAPIs are still
around,
Probably worth adding OS#XYZ here (I recall I saw a ticket a few mins ago?)
https://gerrit.osmocom.org/c/osmo-bsc/+/27818/comment/07e3795b_9db614d2
PS1, Line 1210: * seem to send a RLL_REL_IND for SAPI=3 if there was already one for
SAPI=0 */
this new code added seems to be only applied for TCH according to comment in line 1201. Is
that expected?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27818
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia9caa5b0a5efdc459d94621367376927959a6e65
Gerrit-Change-Number: 27818
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 19 Apr 2022 09:04:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment