[S] Change in osmocom-bb[master]: l1ctl_proto: add 'start_fn' field to UL/DL TBF CFG.req messages - gerrit-log

8 Jun 2023


      Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33222 )
Change subject: l1ctl_proto: add 'start_fn' field to UL/DL TBF CFG.req messages
......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/common/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/33222/comment/680f6a75_b8958a4d 
PS1, Line 1050: 		.start_fn = htonl(start_fn),
...
why are you passing it as a big endian?
Because it's `uint32_t`. Everything larger than one byte in L1CTL PDUs is encoded as big endian (network order).
...
Shouldn't we be doing the same with slotmask then?
Because `slotmask` is `uint8_t` (one byte).
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33222
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ibb6a05165fe1c81268fb0e3674adae4065e78171
Gerrit-Change-Number: 33222
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 08 Jun 2023 07:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment