Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30575 ) Change subject: Convert ms_first_common_ts to struct gprs_rlcmac_pdch ...................................................................... Patch Set 3: (1 comment) File src/gprs_ms.h: https://gerrit.osmocom.org/c/osmo-pcu/+/30575/comment/f71e7daa_b6954f21 PS2, Line 68: _ts Yes, all integers holding a timeslot number should be called "tn" but they are not right now. My point is that there are so many things to fix, improve and clean up in osmo-pcu code that you cannot expect me to do all those at the same time or even in the same patchset. See as an example how many patches I already submitted to rearrange how the control timeslot is stored/passed over to avoid crashing when the TRX changes. I'm basically doing this in bursts from time to time to let the new code settle for a while and to avoid chances of breaking stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I19373939ec104d371e3e91422f018a8175cb0f89 Gerrit-Change-Number: 30575 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Dec 2022 11:44:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment