Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30575 )

Change subject: Convert ms_first_common_ts to struct gprs_rlcmac_pdch ......................................................................

Patch Set 3:

(1 comment)

File src/gprs_ms.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/30575/comment/f71e7daa_b6954f21 PS2, Line 68: _ts

The problem is that '_ts' in this repo is still used for fields holding timeslot number in some plac […]

Yes, all integers holding a timeslot number should be called "tn" but they are not right now. My point is that there are so many things to fix, improve and clean up in osmo-pcu code that you cannot expect me to do all those at the same time or even in the same patchset. See as an example how many patches I already submitted to rearrange how the control timeslot is stored/passed over to avoid crashing when the TRX changes.

I'm basically doing this in bursts from time to time to let the new code settle for a while and to avoid chances of breaking stuff.