Attention is currently required from: laforge.
wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/33953 )
Change subject: Added calls to stub decryption functions for MAC resources ......................................................................
Patch Set 3:
(1 comment)
File src/tetra_upper_mac.c:
https://gerrit.osmocom.org/c/osmo-tetra/+/33953/comment/35370629_c776ea50 PS3, Line 301: m
so you want to move the tail but not change the length (as msgb_get does). […]
I agree, but it is in line with what's also present at several other locations in this file. I'd suggest I file a separate commit where I replace the "msg->tail -= var" construction with msgb_get(msg, var) calls. I can then also properly test the change doesn't inadvertedly break things.