Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39744?usp=email ) Change subject: [4/6] personalization: refactor Pin, Adm ...................................................................... Patch Set 3: Code-Review-1 (2 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39744/comment/9188e789_e4c36d73?usp=em… : PS3, Line 408: return (pe for pe in l if pe.type == wanted_type) this seems a bit like a reimplementation of the ProfileElementList.pe_by_type convenience dict? https://gerrit.osmocom.org/c/pysim/+/39744/comment/b5570315_80fb5929?usp=em… : PS3, Line 452: def _apply_pinvalue(pe: ProfileElement, keyReference, val_bytes): so according to this type annotation, 'pe' is a single ProfileElement. But then belwo you pass it into the method that expects a list (obtain_all_pe_from_pelist)? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I54aef10b6d4309398d4b779a3740a7d706d68603 Gerrit-Change-Number: 39744 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 17:06:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes