Attention is currently required from: neels.

laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39744?usp=email )

Change subject: [4/6] personalization: refactor Pin, Adm ......................................................................

Patch Set 3: Code-Review-1

(2 comments)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/39744/comment/9188e789_e4c36d73?usp=ema... : PS3, Line 408: return (pe for pe in l if pe.type == wanted_type) this seems a bit like a reimplementation of the ProfileElementList.pe_by_type convenience dict?

https://gerrit.osmocom.org/c/pysim/+/39744/comment/b5570315_80fb5929?usp=ema... : PS3, Line 452: def _apply_pinvalue(pe: ProfileElement, keyReference, val_bytes): so according to this type annotation, 'pe' is a single ProfileElement. But then belwo you pass it into the method that expects a list (obtain_all_pe_from_pelist)?