Attention is currently required from: neels.

Patch set 3:Code-Review -1

View Change

2 comments:

• File pySim/esim/saip/personalization.py:

  • Patch Set #3, Line 408: return (pe for pe in l if pe.type == wanted_type)

    this seems a bit like a reimplementation of the ProfileElementList.pe_by_type convenience dict?

  • Patch Set #3, Line 452: def _apply_pinvalue(pe: ProfileElement, keyReference, val_bytes):

    so according to this type annotation, 'pe' is a single ProfileElement. But then belwo you pass it into the method that expects a list (obtain_all_pe_from_pelist)?

To view, visit change 39744. To unsubscribe, or for help writing mail filters, visit settings.